Fix build.rs #110
Merged
Fix build.rs #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## trunk #110 +/- ##
=======================================
Coverage 76.86% 76.86%
=======================================
Files 11 11
Lines 2027 2027
Branches 2027 2027
=======================================
Hits 1558 1558
Misses 86 86
Partials 383 383 |
|
did you rewrite history? |
|
I fixed it somehow. |
|
This looks good. Thanks. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I described here that build.rs will always trigger a rebuild on the second build (but then settle after that) #105 (comment) and this PR fixes that issue.
The fix is just to remove the line
println!("cargo:rerun-if-changed={}", default_precision_rs_path.display());This line doesnt make any sense because the path is an output not an input.
We only want to rebuild if our inputs change not our outputs.
The line was originally introduced here: b35a851
And then a workaround that missed the root cause was introduced here: https://github.com/akubera/bigdecimal-rs/pull/106/files
I also cleaned up the whole thing because it was way more complicated than it needed to be.